Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note that headless repositories are possible #2926

Open
wants to merge 2 commits into
base: 4.8.x
Choose a base branch
from
Open

Add note that headless repositories are possible #2926

wants to merge 2 commits into from
+96 −4

Conversation

rlconst
Copy link
Contributor

@rlconst rlconst commented Apr 30, 2024

I tried to create two un-bound repositories with raw queries and it perfectly works. Either documentation is outdated or there are some pitfalls.

sdelamo
sdelamo requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test of what now works and it used not work?

@rlconst rlconst changed the base branch from 4.7.x to 4.8.x May 10, 2024 06:41
@rlconst
Copy link
Contributor Author

rlconst commented May 10, 2024

@sdelamo I added example of headless repos

@rlconst rlconst changed the title Update repositories.adoc Add note that headless repositories are possible May 10, 2024
@rlconst
Copy link
Contributor Author

rlconst commented May 10, 2024

I'm not sure if oracle migration is relevant to my changes

@graemerocher
Copy link
Contributor

seems the syntax for creating duality JSON views in Oracle changes in the latest published docker images, we will need to investigate but this seems unrelated yes

@dstepanov
Copy link
Contributor

Maybe the text can be rephrased to explain that you cannot use GenericRepository and friends without an entity.

@sdelamo sdelamo requested a review from dstepanov May 13, 2024 09:33
@radovanradic
Copy link
Contributor

seems the syntax for creating duality JSON views in Oracle changes in the latest published docker images, we will need to investigate but this seems unrelated yes

Yes, latest oracle-free image is giving this error. Looking now for changes needed to fix it.

@radovanradic
Copy link
Contributor

seems the syntax for creating duality JSON views in Oracle changes in the latest published docker images, we will need to investigate but this seems unrelated yes

Yes, latest oracle-free image is giving this error. Looking now for changes needed to fix it.

@rlconst I have pushed fix to 4.8.x, please try pulling latest changes and the test should pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo requested changes

@dstepanov dstepanov Awaiting requested review from dstepanov

Assignees
No one assigned
Labels
type: docs
Projects
No open projects
4.5.0 Release
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rlconst @graemerocher @dstepanov @radovanradic @sdelamo